Pin Zig CI to the version against which the template was written #3195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
fibonacci1729
approved these changes
Jul 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on @seun-ja's investigation of the Zig CI errors and his work in #3192. The motivation for creating a separate PR was to uncouple it from the signals work. I also switched Zig CI over from the unmaintained
goto-bus-stopaction to themluggaction recommended as a replacement.I've followed @seun-ja in pinning the version in CI rather than updating the template, because the "writergate" changes (ziglang/zig#24329) are not yet in a release. We could instead track
latestin the action, which would have the same effect for now but alert us when writergate went live, so that we were prompted to update the template, but that would make us a hostage to fortune in terms of CI suddenly going red!