fix(tests): Re-enable MQTT and Postgres tests #3163
Conversation
PhantomInTheWire
force-pushed
the
fix/postgres-mqtt-tests
branch
from
b7c00c1 to
3913626
Compare
|
We had a pass - I kicked off a re-run to see if we can get a flake |
PhantomInTheWire
force-pushed
the
fix/postgres-mqtt-tests
branch
from
b8241c2 to
ee99acb
Compare
Signed-off-by: Karan <karanlokchandani@protonmail.com>
PhantomInTheWire
force-pushed
the
fix/postgres-mqtt-tests
branch
from
9031f2a to
fa3e779
Compare
|
@itowlson I've squashed all necessary changes. For context, all previous runs of all-integration-tests were executed on ubuntu-latest, which allowed them to run on my fork's PRs. However, I've now switched it back to the custom Spin runner. |
|
Excellent, thanks! Sorry for the slow turmarounds here, it's making me manually approve each re-run, but I will try to stay across it. |
|
Everything is in place and all the tests pass, waiting for your review @itowlson |
|
Thank you @PhantomInTheWire! I'm planning to re-run the CI a few times to see if the flakes re-appear, so please don't worry if things go back to 'running.' I'll take a look at the changes in the meantime. |
| @@ -14,5 +14,5 @@ component = "test" | |||
|
|
|||
| [component.test] | |||
| source = "%{source=outbound-postgres}" | |||
| allowed_outbound_hosts = ["postgres://{{ pg_host }}:%{port=5432}"] | |||
| environment = { DB_URL = "postgres://postgres:postgres@localhost:%{port=5432}/spin_dev" } | |||
| allowed_outbound_hosts = ["postgres://{{ pg_host }}:5432"] | |||
There was a problem hiding this comment.
Are the changes away from placeholder ports needed? I believe we did this so that test instances could be brought up on ports determined at runtime, and it would be good to keep it. If it's not working, it would be good to understand why. (But if that's involved in the flakiness, we can probably punt on it for now.) cc @rylev for thoughts and insight
| @@ -191,6 +191,20 @@ jobs: | |||
| # run on a larger runner for more SSD/resource access | |||
| runs-on: ubuntu-22.04-4core-spin | |||
| if: ${{ github.repository_owner == 'spinframework' }} | |||
| services: | |||
| postgres: | |||
There was a problem hiding this comment.
Hmm, I thought we were dockerising the Postgres instance, but maybe that's been part of the problem. Again, I'd like to get Ryan's input on making it part of the CI image instead (I'm not for or against it, I just want to hear from someone who knows this bit of the system better than I do!).
|
Bother, that's a flake in MQTT. I saw you updated the settings for Postgres; do you think something similar needs to be done for MQTT? |
This PR re-enables the previously ignored
outbound-postgresandoutbound-postgres-variable-permissiontests. It also fixes their flakiness.fixes: #2907
high-level changes: