Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(github-org-name): replace github.com/spinkube with github.com/spinframework #339

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

0xE282B0
Copy link
Collaborator

@0xE282B0 0xE282B0 commented Mar 1, 2025

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

…m/spinframework

Signed-off-by: Sven Pfennig <sven.pfennig@hetzner-cloud.de>
@0xE282B0 0xE282B0 requested review from phyrog, voigt and vdice March 1, 2025 20:47
Copy link

github-actions bot commented Mar 1, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@voigt
Copy link
Member

voigt commented Mar 3, 2025

Generally the change looks good to me. However, helm_install_smoke_test is failing. Could you please check if it is related to your changes?

@vdice
Copy link
Collaborator

vdice commented Mar 3, 2025

The smoke test failed due to the example app not being able to pull the reference (ghcr.io/spinframework/spin-operator/hello-world:20240909-145818-g30def7d doesn't exist as the tag was pushed to the older spinkube org registry)

Tests should succeed (or at least proceed further!) if the reference is updated to: ghcr.io/spinframework/spin-operator/hello-world:20250206-205102-gf007281

Copy link
Collaborator

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the test app reference update and making sure test automation passes, otherwise looks great.

Co-authored-by: Vaughn Dice <vaughn.dice@fermyon.com>
@0xE282B0 0xE282B0 merged commit 612fbba into main Mar 5, 2025
18 checks passed
@0xE282B0 0xE282B0 deleted the feat-replace-spinkube-org branch March 5, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants