Fix test breaking when a proxy is configured on the host #5471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
kfox1111
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
kfox1111
commented
Sep 5, 2024
| @@ -79,13 +79,14 @@ func TestValidateChallenge(t *testing.T) { | |||
| })) | |||
| defer func() { testServer.Close() }() | |||
|
|
|||
| transport := http.DefaultTransport.(*http.Transport).Clone() | |||
There was a problem hiding this comment.
The DefaultTransport honors HTTP_PROXY env vars. We should actually start from a new Transport like elsewhere.
MarcosDY
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the host has HTTP_PROXY settings defined, one of the new http_challege node agent tests will forward the request to the proxy from the local environment, which can't handle the request, rather then redirecting back to the test fixture properly. This patch changes the test to function like the rest of the http_challenge tests and calls back to the test fixture directly.