-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce flakiness in evict-agent CI #5386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
amoore877
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
August 14, 2024 22:26
2 tasks
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
some potential flake here:
|
azdagron
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @amoore877 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Increase CI reliability
Description of change
Noticed in pushing #5383 that this test would sometimes fail with no explanation. This test is also unrelated to the changes in #5383, so it is flaky. See #5383 (comment) / https://github.com/spiffe/spire/actions/runs/10378374004/job/28734731515?pr=5383#step:9:1301 for unexpected 404 error.
While here, also split up this test into more discrete action units.
Which issue this PR fixes
N/A