Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce flakiness in evict-agent CI #5386

Merged
merged 15 commits into from
Aug 24, 2024
Merged

Conversation

amoore877
Copy link
Member

@amoore877 amoore877 commented Aug 14, 2024

Pull Request check list

  • Commit conforms to CONTRIBUTING.md?
  • Proper tests/regressions included?
  • [NA] Documentation updated?

Affected functionality
Increase CI reliability

Description of change
Noticed in pushing #5383 that this test would sometimes fail with no explanation. This test is also unrelated to the changes in #5383, so it is flaky. See #5383 (comment) / https://github.com/spiffe/spire/actions/runs/10378374004/job/28734731515?pr=5383#step:9:1301 for unexpected 404 error.

While here, also split up this test into more discrete action units.

Which issue this PR fixes
N/A

Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
@azdagron azdagron self-assigned this Aug 15, 2024
@amoore877
Copy link
Member Author

some potential flake here:
https://github.com/spiffe/spire/actions/runs/10459940073/job/28965089994#step:6:66

ok  	github.com/spiffe/spire/pkg/agent/plugin/nodeattestor/sshpop	0.294s
# github.com/google/go-tpm-tools/simulator/internal
In file included from include.c:153:
D:\golang\modcache\github.com\google\go-tpm-tools@v0.4.4\simulator\ms-tpm-20-ref\TPMCmd\tpm\src/crypt/CryptCmac.c: In function 'CryptCmacEnd':
D:\golang\modcache\github.com\google\go-tpm-tools@v0.4.4\simulator\ms-tpm-20-ref\TPMCmd\tpm\src/crypt/CryptCmac.c:164:44: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
  164 |         subkey.t.buffer[subkey.t.size - 1] ^= xorVal;
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
In file included from D:\golang\modcache\github.com\google\go-tpm-tools@v0.4.4\simulator\ms-tpm-20-ref\TPMCmd\tpm\include/Global.h:79,
                 from D:\golang\modcache\github.com\google\go-tpm-tools@v0.4.4\simulator\ms-tpm-20-ref\TPMCmd\tpm\include/Tpm.h:52,
                 from D:\golang\modcache\github.com\google\go-tpm-tools@v0.4.4\simulator\ms-tpm-20-ref\TPMCmd\tpm\src/support/Global.c:57,
                 from include.c:17:
D:\golang\modcache\github.com\google\go-tpm-tools@v0.4.4\simulator\ms-tpm-20-ref\TPMCmd\tpm\include/TpmTypes.h:1350:29: note: at offset -1 into destination object 'buffer' of size 16
 1350 |         BYTE                buffer[MAX_SYM_BLOCK_SIZE];
      |                             ^~~~~~

Copy link
Member

@azdagron azdagron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @amoore877 !

@azdagron azdagron merged commit 1eb4340 into spiffe:main Aug 24, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants