Allow DelegatedIdentity API clients to subscribe by PID #5272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
bleggett
changed the title
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett
changed the title
bleggett
force-pushed
the
bleggett/pids-thru-delegate-api
branch
from
fd38b74
to
c2f2f2c
Compare
bleggett
commented
Jul 8, 2024
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
|
@azdagron et al this end is now passing CI - PTAL at the |
|
(WAS passing until I resynced with |
|
Hey @bleggett! Just a friendly ping about addressing the comments. I think we're pretty close here! |
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
|
@azdagron everything should be addressed, lmk if you have further comments, ty! |
|
ty all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
DelegateIdentity API
Description of change
This is the impl side of spiffe/spire-api-sdk#58
For this to build you need to locally check out thespire-api-sdkfork @40d1bc186c2da087756115d9e6eb45e75aef0b3b as a sibling of this repo, so until/if that is merged, this should not be.CI will not pass until ☝️ happens!Ended up being simpler than I expected.
Note that docs and examples are pending still.Which issue this PR fixes
#5019