Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce reattest to renew on server #5204

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Enforce reattest to renew on server #5204

merged 4 commits into from
Jun 10, 2024

Conversation

azdagron
Copy link
Member

This has been a warning but is now enforced for 1.10.0.

@azdagron
Enforce reattest to renew on server
01fd05c 
This has been a warning but is now enforced for 1.10.0.

Signed-off-by: Andrew Harding <azdagron@gmail.com>
@azdagron azdagron added this to the 1.10.0 milestone Jun 10, 2024
amartinezfayo
amartinezfayo reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we need to update our node-attestation integration test? is it trying to renew with x509pop?

azdagron and others added 3 commits June 10, 2024 09:29
@azdagron
adjust node-attestation test
3aa7d80 
Signed-off-by: Andrew Harding <azdagron@gmail.com>
@azdagron
fix lint
837fc96 
Signed-off-by: Andrew Harding <azdagron@gmail.com>
@amartinezfayo
Merge branch 'main' into enforce-reattest-to-renew
352bbf2
amartinezfayo
amartinezfayo approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@amartinezfayo amartinezfayo merged commit 18767a7 into spiffe:main Jun 10, 2024
33 checks passed
@sorindumitru
Copy link
Contributor

Should we also remove the disable_reattest_to_renew configurable in spire-agent? Doesn't seem to make sense anymore now that the server forces it to re-attest.

@azdagron
Copy link
Member Author

Thanks for catching that @sorindumitru. I've opened #5217.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amartinezfayo amartinezfayo amartinezfayo approved these changes

@evan2645 evan2645 Awaiting requested review from evan2645 evan2645 is a code owner

@MarcosDY MarcosDY Awaiting requested review from MarcosDY MarcosDY is a code owner

@rturner3 rturner3 Awaiting requested review from rturner3 rturner3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@azdagron @sorindumitru @amartinezfayo