Fetch agent selectors when refreshing event based cache #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorindumitru
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
sorindumitru
force-pushed
the
event-node-alias
branch
from
2894186 to
8d6ed6d
Compare
Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
sorindumitru
force-pushed
the
event-node-alias
branch
from
8d6ed6d to
5529949
Compare
azdagron
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Good catch! Thanks for opening, @sorindumitru !
I don't think we need all the changes related to the fake data store though. Let's just always configure it to populate the events tables.
| log, _ := test.NewNullLogger() | ||
|
|
||
| ds := sql.New(log, false) |
There was a problem hiding this comment.
Let's just set this to true since all it influences is whether or not the events table gets populated based on database changes.
This reverts commit 838eaf2. Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
azdagron
reviewed
Jan 17, 2024
Signed-off-by: Andrew Harding <azdagron@gmail.com>
|
Fixed it. |
azdagron
approved these changes
Jan 18, 2024
|
When should we expect this to be merged? We hit a similar issue and are hoping to cherry-pick this patch from |
|
As soon as CI/CD passes. Unrelated failures abound. |
Thanks for taking care of that, looks like I forgot to actually commit those changes 😬 |
faisal-memon
pushed a commit
to faisal-memon/spire
that referenced
this pull request
Feb 7, 2024
Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net> Signed-off-by: Faisal Memon <fymemon@yahoo.com>
sriyer
pushed a commit
to spire-vault/spire
that referenced
this pull request
Feb 23, 2024
Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
rushi47
pushed a commit
to rushi47/spire
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
spire-server: starting with 1.8.7 when event based cache is enabled
Description of change
The event based cache doesn't properly refersh the attested agent/node. It fetches the list of updated agents but does not fetch the selector list for them. This leads to issues if you add a node alias for a new agent (attested after the initial cache population which handles the selectors ok); due to the lack of selectors in the cached agent entry it won't be able to determine that it is also authorized for that new alias. Workload registration entries parented to that node alias will not appear in the authorized entries list for the agent.
The fix for this is easy, also fetch the selectors after fetching the attested node information. If anyone can shed some light as to why the API works like that, it would be good since it does seem a bit error prone.