Fix SyncAuthorizedEntries test race #4769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SyncAuthorizedEntries test is set up to optionally send a request, depending on the expectations of the test case. The "no caller ID" and "fetcher fails" test cases are currently set up to send the request on the stream. However, in this instances, the handler exits before reading the request off the stream due to the respective expected failures. Timing conditions still allowed the requests to be sent successfully most of the time but caused intermittent failures, particularly when being run in resource constrained environments (e.g. GH actions). This change fixes the test cases by not attempting to send the request on the stream. Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
requested review from
evan2645,
amartinezfayo,
MarcosDY and
rturner3
as code owners
sriyer
pushed a commit
to spire-vault/spire
that referenced
this pull request
Feb 23, 2024
The SyncAuthorizedEntries test is set up to optionally send a request, depending on the expectations of the test case. The "no caller ID" and "fetcher fails" test cases are currently set up to send the request on the stream. However, in this instances, the handler exits before reading the request off the stream due to the respective expected failures. Timing conditions still allowed the requests to be sent successfully most of the time but caused intermittent failures, particularly when being run in resource constrained environments (e.g. GH actions). This change fixes the test cases by not attempting to send the request on the stream. Signed-off-by: Andrew Harding <azdagron@gmail.com>
rushi47
pushed a commit
to rushi47/spire
that referenced
this pull request
Apr 11, 2024
The SyncAuthorizedEntries test is set up to optionally send a request, depending on the expectations of the test case. The "no caller ID" and "fetcher fails" test cases are currently set up to send the request on the stream. However, in this instances, the handler exits before reading the request off the stream due to the respective expected failures. Timing conditions still allowed the requests to be sent successfully most of the time but caused intermittent failures, particularly when being run in resource constrained environments (e.g. GH actions). This change fixes the test cases by not attempting to send the request on the stream. Signed-off-by: Andrew Harding <azdagron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SyncAuthorizedEntries test is set up to optionally send a request, depending on the expectations of the test case. The "no caller ID" and "fetcher fails" test cases are currently set up to send the request on the stream. However, in these instances, the handler exits before reading the request off the stream due to the respective expected failures. Timing conditions still allowed the requests to be sent successfully most of the time but caused intermittent failures, particularly when being run in resource constrained environments (e.g. GH actions).
This change fixes the test cases by not attempting to send the request on the stream.