[githooks] Remove #4761
Merged
[githooks] Remove #4761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instructions as written resulted in a broken link for the pre-commit git hook. Use `pushd`, `popd`, and `git rev-parse --show-toplevel` to correct it. Signed-off-by: Zack Train <ztrain@uber.com>
zmt
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
zmt
added a commit
to zmt/spire
that referenced
this pull request
Dec 27, 2023
Signed-off-by: Zack Train <ztrain@uber.com>
azdagron
previously approved these changes
Jan 2, 2024
|
This fix is great. As discussed in the contrib sync, it's probably also ok to just remove this git hook and doc section. Most go setups these days do |
Signed-off-by: Zack Train <ztrain@uber.com>
azdagron
previously approved these changes
Jan 2, 2024
|
@zmt can you resolve conflicts? thanks!!! |
MarcosDY
approved these changes
Jan 4, 2024
sriyer
pushed a commit
to spire-vault/spire
that referenced
this pull request
Feb 23, 2024
* [docs] Fix git hook bug in CONTRIBUTING.md The instructions as written resulted in a broken link for the pre-commit git hook. Use `pushd`, `popd`, and `git rev-parse --show-toplevel` to correct it. Signed-off-by: Zack Train <ztrain@uber.com> * [githooks] Remove deprecated gofmt pre-update hook Signed-off-by: Zack Train <ztrain@uber.com> --------- Signed-off-by: Zack Train <ztrain@uber.com> Co-authored-by: Marcos Yacob <marcos.yacob@hpe.com>
rushi47
pushed a commit
to rushi47/spire
that referenced
this pull request
Apr 11, 2024
* [docs] Fix git hook bug in CONTRIBUTING.md The instructions as written resulted in a broken link for the pre-commit git hook. Use `pushd`, `popd`, and `git rev-parse --show-toplevel` to correct it. Signed-off-by: Zack Train <ztrain@uber.com> * [githooks] Remove deprecated gofmt pre-update hook Signed-off-by: Zack Train <ztrain@uber.com> --------- Signed-off-by: Zack Train <ztrain@uber.com> Co-authored-by: Marcos Yacob <marcos.yacob@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instructions as written in CONTRIBUTING.md resulted in a broken link for the pre-commit git hook. Per discussion with maintainers, the gofmt pre-commit hook is essentially obsolete. Rather than correct the documentation, just remove it and the reference to it in CONTRIBUTING.md.
Pull Request check list
Affected functionality
Remove the pre-commit git hook and broken symlink instructions.
Description of change
Started as a documentation fix, but became removal of dead code.