agent: fix JWT cache #4309
Merged
agent: fix JWT cache #4309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JWT cache in the agent has a bug whereby we do not distinguish
between audience sets {"ab", "cd"} and {"a", "bcd"} (for example) due to
the way we build the cache keys.
Fix this.
Signed-off-by: Carlo Teubner <cteubner1@bloomberg.net>
c4rlo
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
Neniel
pushed a commit
to Neniel/spire
that referenced
this pull request
Jul 10, 2023
The JWT cache in the agent has a bug whereby we do not distinguish
between audience sets {"ab", "cd"} and {"a", "bcd"} (for example) due to
the way we build the cache keys.
Fix this.
Signed-off-by: Carlo Teubner <cteubner1@bloomberg.net>
Signed-off-by: Neniel <11655196+Neniel@users.noreply.github.com>
Neniel
pushed a commit
to Neniel/spire
that referenced
this pull request
Jul 21, 2023
The JWT cache in the agent has a bug whereby we do not distinguish
between audience sets {"ab", "cd"} and {"a", "bcd"} (for example) due to
the way we build the cache keys.
Fix this.
Signed-off-by: Carlo Teubner <cteubner1@bloomberg.net>
Signed-off-by: Neniel <11655196+Neniel@users.noreply.github.com>
Neniel
pushed a commit
to Neniel/spire
that referenced
this pull request
Aug 24, 2023
The JWT cache in the agent has a bug whereby we do not distinguish
between audience sets {"ab", "cd"} and {"a", "bcd"} (for example) due to
the way we build the cache keys.
Fix this.
Signed-off-by: Carlo Teubner <cteubner1@bloomberg.net>
Signed-off-by: Neniel <11655196+Neniel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
JWT-SVID caching in spire-agent.
Description of change
The JWT cache in the agent has a bug whereby we do not distinguish between audience sets
{"ab", "cd"}and{"a", "bcd"}(for example) due to the way we build the cache keys.Fix this.
Which issue this PR fixes
None I'm aware of.