Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement structured logging for gRPC errors on SPIRE agent #4262

Merged
merged 16 commits into from
Sep 1, 2023
Merged

Implement structured logging for gRPC errors on SPIRE agent #4262

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7129268
implement structured logging for grpc errors on spire agented logging…
Neniel Jun 15, 2023
d1cfb7a
reduce branching when handling grpc errors
Neniel Jun 16, 2023
74ae833
add helper function
Neniel Jun 16, 2023
2da3732
add gRPC fields if applicable and the error
Neniel Jun 19, 2023
b870c4d
add unit tests
Neniel Jun 19, 2023
a92fed7
goimport file
Neniel Jun 20, 2023
ef11605
add tests for uncovered cases
Neniel Jun 27, 2023
f524f17
Update pkg/agent/client/client.go
Neniel Jun 27, 2023
6806c8b
update new tests
Neniel Jun 30, 2023
aeac9f5
call withErrorFields once in fetchBundles
Neniel Jul 4, 2023
02e8ac7
use table driven test
Neniel Jul 10, 2023
a090c43
fix expires at and issued at dates
Neniel Jul 10, 2023
f47f264
use logger variable
Neniel Jul 10, 2023
498ff60
fix lint issue
Neniel Jul 21, 2023
407362a
sort imports
Neniel Jul 25, 2023
e5043f1
Merge branch 'main' into structured-logging-for-grpc-errors-on-spire-…
azdagron Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
goimport file 
Signed-off-by: Neniel <11655196+Neniel@users.noreply.github.com>
  • Loading branch information
@Neniel
Neniel committed Aug 24, 2023
commit a92fed7e2c44e6c65da55259309ecf0c6f4c0ef2
4 changes: 2 additions & 2 deletions pkg/agent/client/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,20 @@ import (
"crypto"
"crypto/x509"
"errors"
"github.com/sirupsen/logrus"
"github.com/spiffe/spire/pkg/common/telemetry"
"sync"
"testing"
"time"

"github.com/google/go-cmp/cmp"
"github.com/sirupsen/logrus"
"github.com/sirupsen/logrus/hooks/test"
"github.com/spiffe/go-spiffe/v2/spiffeid"
agentv1 "github.com/spiffe/spire-api-sdk/proto/spire/api/server/agent/v1"
bundlev1 "github.com/spiffe/spire-api-sdk/proto/spire/api/server/bundle/v1"
entryv1 "github.com/spiffe/spire-api-sdk/proto/spire/api/server/entry/v1"
svidv1 "github.com/spiffe/spire-api-sdk/proto/spire/api/server/svid/v1"
"github.com/spiffe/spire-api-sdk/proto/spire/api/types"
"github.com/spiffe/spire/pkg/common/telemetry"
"github.com/spiffe/spire/proto/spire/common"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
Expand Down