Produce serial number selector in x509pop NodeAttestor #4216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The serial number of an X.509 certificate is supposed to be unique and may be a useful way to organize authorized workload entries. Signed-off-by: Ryan Turner <turner@uber.com>
rturner3
requested review from
evan2645,
amartinezfayo,
azdagron and
MarcosDY
as code owners
added 3 commits
June 8, 2023 14:16
Signed-off-by: Ryan Turner <turner@uber.com>
…ate parameter Also remove mention of Subject.CommonName as a path template field, as it is different from the certificate serial number. Signed-off-by: Ryan Turner <turner@uber.com>
Signed-off-by: Ryan Turner <turner@uber.com>
amartinezfayo
approved these changes
Jun 13, 2023
Neniel
pushed a commit
to Neniel/spire
that referenced
this pull request
Jul 21, 2023
* Produce serial number selector in x509pop NodeAttestor The serial number of an X.509 certificate is supposed to be unique and may be a useful way to organize authorized workload entries. Signed-off-by: Ryan Turner <turner@uber.com> * Represent serial number as hex Signed-off-by: Ryan Turner <turner@uber.com> * Document x509pop serialnumber selector and Agent SPIFFE ID path template parameter Also remove mention of Subject.CommonName as a path template field, as it is different from the certificate serial number. Signed-off-by: Ryan Turner <turner@uber.com> * Fix agent ID path template field name Signed-off-by: Ryan Turner <turner@uber.com> --------- Signed-off-by: Ryan Turner <turner@uber.com> Co-authored-by: Evan Gilman <evan@spirl.com> Signed-off-by: Neniel <11655196+Neniel@users.noreply.github.com>
Neniel
pushed a commit
to Neniel/spire
that referenced
this pull request
Aug 24, 2023
* Produce serial number selector in x509pop NodeAttestor The serial number of an X.509 certificate is supposed to be unique and may be a useful way to organize authorized workload entries. Signed-off-by: Ryan Turner <turner@uber.com> * Represent serial number as hex Signed-off-by: Ryan Turner <turner@uber.com> * Document x509pop serialnumber selector and Agent SPIFFE ID path template parameter Also remove mention of Subject.CommonName as a path template field, as it is different from the certificate serial number. Signed-off-by: Ryan Turner <turner@uber.com> * Fix agent ID path template field name Signed-off-by: Ryan Turner <turner@uber.com> --------- Signed-off-by: Ryan Turner <turner@uber.com> Co-authored-by: Evan Gilman <evan@spirl.com> Signed-off-by: Neniel <11655196+Neniel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serial number of an X.509 certificate is supposed to be unique and may be a useful way to organize authorized workload entries.
Which issue this PR fixes
Fixes #4215