Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on key metadata files of KMS plugins #4375

Closed
amartinezfayo opened this issue Jul 28, 2023 · 4 comments
Closed

Remove dependency on key metadata files of KMS plugins #4375

amartinezfayo opened this issue Jul 28, 2023 · 4 comments
Labels
priority/backlog Issue is approved and in the backlog

Comments

@amartinezfayo
Copy link
Member

As part of the goal of removing server dependency on on-disk data, we need the KMS plugins to avoid having to store a file that stores an auto-generated server ID, that's used to keep track of the keys managed by the plugin.
This file is referenced as the key metadata file by the KMS plugins.

@amartinezfayo amartinezfayo added the priority/backlog Issue is approved and in the backlog label Jul 31, 2023
keeganwitt added a commit to keeganwitt/spire that referenced this issue Nov 28, 2023
keeganwitt added a commit to keeganwitt/spire that referenced this issue Nov 28, 2023
Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
keeganwitt added a commit to keeganwitt/spire that referenced this issue Nov 28, 2023
Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
@keeganwitt
Copy link
Contributor

keeganwitt commented Nov 28, 2023

This ticket said metadata files. Does that mean AWS's key_policy_file and GCP's service_account_file and key_policy_file don't need a way to be avoided?

@amartinezfayo
Copy link
Member Author

None of those configs are a required configuration, so they haven't been targeted as a primary goal to remove the dependency on disk storage for the plugins. If those configs are a problem in your use case, I suggest to explore solutions separately.

keeganwitt added a commit to keeganwitt/spire that referenced this issue Nov 29, 2023
Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
@keeganwitt
Copy link
Contributor

None of those configs are a required configuration, so they haven't been targeted as a primary goal to remove the dependency on disk storage for the plugins. If those configs are a problem in your use case, I suggest to explore solutions separately.

They're not, just confirming I understood the requirements.

@keeganwitt
Copy link
Contributor

If there are any character restrictions for the ID, we should document those too.

sriyer pushed a commit to spire-vault/spire that referenced this issue Feb 23, 2024
* Remove KMS requiring metadata files (closes spiffe#4375)

Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
rushi47 pushed a commit to rushi47/spire that referenced this issue Apr 11, 2024
* Remove KMS requiring metadata files (closes spiffe#4375)

Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Issue is approved and in the backlog
Projects
None yet
Development

No branches or pull requests

2 participants