Upgrade to go-jose/v4 #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcpherrinm
requested review from
amartinezfayo,
evan2645 and
azdagron
as code owners
This upgrades from /v3 to /v4, which had a few breaking changes: 1. Compact Serialization is now the only supported type, and the method name switched to just Serialize() 2. ParseSigned takes a list of supported algorithms, building in the supported check 3. Audience in jwt.Expected was renamed AnyAudience and does an intersection check, matching the jwt spec and expected behavior better Signed-off-by: Matthew McPherrin <git@mcpherrin.ca>
|
Duplicated by #276 |
|
Thanks for opening this, @mcpherrinm! @rturner3 missed this when opening 276 :) Looks like the approaches are almost identical. Appreciate the contrib anyway! |
|
If you could cut a new release soon that would be great, so we can update ghostunnel’s go-spiffe to include the upgraded go-jose |
|
Yes, will do. I can cut a new release first thing tomorrow morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades from /v3 to /v4, which had a few breaking changes: