Enable race detection when running tests #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
requested review from
amartinezfayo,
evan2645 and
azdagron
as code owners
Signed-off-by: Noah Stride <noah.stride@goteleport.com>
strideynet
force-pushed
the
strideynet/enable-race-detection-in-testing
branch
from
e88b77e
to
58060de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
-raceto the invocation ofgo testin thetesttarget of the Makefile. This is generally considered a good practice as it enables catching potential races earlier.Looks like the test suite runs happily with the race detector enabled 🥳
Whilst this can reduce the speed at which the test suite runs, it doesn't look like this produces a significant change for this test suite on my local machine, especially given the relatively small size of the suite at the moment.