Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix chart: Values.multus.multusCNI.uninstall does not take effect #2974

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fix chart: Values.multus.multusCNI.uninstall does not take effect #2974

merged 1 commit into from
Dec 22, 2023

Conversation

cyclinder
Copy link
Collaborator

Thanks for contributing!

What type of PR is this?

  • kind/bug

What this PR does / why we need it:

chart: make Values.multus.multusCNI.uninstall to sense

Which issue(s) this PR fixes:

Fixes #2972

Special notes for your reviewer:

@cyclinder cyclinder added cherrypick-release-v0.7 Cherry-pick the PR to branch release-v0.7. release/bug cherrypick-release-v0.8 Cherry-pick the PR to branch release-v0.8. cherrypick-release-v0.9 labels Dec 21, 2023
@cyclinder cyclinder force-pushed the charts/multus_uninstalll branch from ec6f6d0 to 35a627b Compare December 21, 2023 10:47
@weizhoublue weizhoublue changed the title chart: make Values.multus.multusCNI.uninstall to sense fix: Values.multus.multusCNI.uninstall does not take effect Dec 21, 2023
@weizhoublue
Copy link
Collaborator

sign off

@weizhoublue weizhoublue changed the title fix: Values.multus.multusCNI.uninstall does not take effect fix chart: Values.multus.multusCNI.uninstall does not take effect Dec 22, 2023
@cyclinder cyclinder force-pushed the charts/multus_uninstalll branch 2 times, most recently from ebccb70 to 5e5e7bf Compare December 22, 2023 05:02
@cyclinder
chart: make Values.multus.multusCNI.uninstall to sense
e29ab38 
Signed-off-by: qifeng.guo@daocloud.io
@cyclinder cyclinder force-pushed the charts/multus_uninstalll branch from 5e5e7bf to e29ab38 Compare December 22, 2023 05:04
@cyclinder
Copy link
Collaborator Author 

##[debug]}
Redirecting to blob download url: https://productionresultssa6.blob.core.windows.net/actions-results/383bc6db-35f9-4f62-9c96-77aac19d6434/workflow-job-run-47eebfc0-3fc8-55d8-2ea4-4641d9c01654/artifacts/image-tar-spiderpool-controller.zip
Starting download of artifact to: /home/runner/work/spiderpool/spiderpool/test/.download
Error: Unable to download artifact(s): Unable to download and extract artifact: Request timeout: /actions-results/383bc6db-35f9-4f62-9c96-77aac19d6434/workflow-job-run-47eebfc0-3fc8-55d8-2ea4-4641d9c01654/artifacts/image-tar-spiderpool-controller.zip?se=2023-12-22T05%3A19%3A39Z&sig=ScLOKj8bmOzcN0rgvx%2Bq8OlWhmhoG0eI21NkdeEYoao%3D&sp=r&spr=https&sr=b&st=2023-12-22T05%3A09%3A39Z&sv=2021-12-02

@weizhoublue weizhoublue merged commit 3b2cf24 into spidernet-io:main Dec 22, 2023
41 checks passed
@weizhoublue weizhoublue mentioned this pull request Dec 22, 2023
Closed
github-actions bot pushed a commit that referenced this pull request Dec 22, 2023
@weizhoublue
Merge pull request #2974 from cyclinder/charts/multus_uninstalll
c0b163d 
fix chart: Values.multus.multusCNI.uninstall does not take effect

Signed-off-by: robot <robot@example.com>
@weizhoublue weizhoublue mentioned this pull request Dec 22, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Dec 22, 2023
@weizhoublue
Merge pull request #2974 from cyclinder/charts/multus_uninstalll
1237fb9 
fix chart: Values.multus.multusCNI.uninstall does not take effect

Signed-off-by: robot <robot@example.com>
@weizhoublue weizhoublue mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weizhoublue weizhoublue weizhoublue approved these changes

@Icarus9913 Icarus9913 Icarus9913 approved these changes

Assignees
No one assigned
Labels
cherrypick-release-v0.7 Cherry-pick the PR to branch release-v0.7. cherrypick-release-v0.8 Cherry-pick the PR to branch release-v0.8. cherrypick-release-v0.9 release/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multus.uninstall is set to true and does not take effect
3 participants
@cyclinder @weizhoublue @Icarus9913