Added logging to help with debugging

spicywebau · Sep 10, 2016 · cc6077c · cc6077c
1 parent fe0d77d
commit cc6077c
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/embeddedassets/models/EmbeddedAssetsModel.php b/embeddedassets/models/EmbeddedAssetsModel.php
@@ -43,6 +43,8 @@ public static function populateFromAsset(AssetFileModel $asset)
 			}
 			catch(\Exception $e)
 			{
+				EmbeddedAssetsPlugin::log("Error reading embedded asset data on asset {$asset->id} (\"{$e->getMessage()}\")", LogLevel::Error);
+
 				return null;
 			}
 		}

diff --git a/embeddedassets/services/EmbeddedAssetsService.php b/embeddedassets/services/EmbeddedAssetsService.php
@@ -58,10 +58,14 @@ public function parseUrl($url)
 		$essence = new \Essence\Essence();
 		$options = EmbeddedAssetsPlugin::getParameters();
 
+		EmbeddedAssetsPlugin::log("Requesting URL \"{$url}\"");
+
 		$result = $essence->extract($url, $options);
 
 		if($result && $result->html)
 		{
+			EmbeddedAssetsPlugin::log("Embed data found");
+
 			$properties = array();
 
 			foreach($result as $property => $value)
@@ -74,10 +78,17 @@ public function parseUrl($url)
 
 			if(!empty($properties))
 			{
+				EmbeddedAssetsPlugin::log("Some data missing - looking for related Open Graph metadata");
+
 				try
 				{
 					$data = $this->_readExternalFile($url);
 
+					if(!$data)
+					{
+						throw new \Exception("Could not read data");
+					}
+
 					$reader = new \Opengraph\Reader();
 					$reader->parse($data);
 
@@ -87,7 +98,10 @@ public function parseUrl($url)
 						$result->$property = $reader->getMeta($ogProperty);
 					}
 				}
-				catch(\Exception $e) {}
+				catch(\Exception $e)
+				{
+					EmbeddedAssetsPlugin::log("Error requesting/parsing Open Graph metadata (\"{$e->getMessage()}\")", LogLevel::Warning);
+				}
 			}
 		}
 
@@ -160,6 +174,8 @@ public function saveEmbeddedAsset(EmbeddedAssetsModel $media, $folderId)
 			}
 			catch(\Exception $e)
 			{
+				EmbeddedAssetsPlugin::log("Error saving embedded asset (\"{$e->getMessage()}\")", LogLevel::Error);
+
 				if($transaction)
 				{
 					$transaction->rollback();
@@ -207,6 +223,8 @@ private function _storeFile(EmbeddedAssetsModel $media, $folderId)
 
 		if($existingFile)
 		{
+			EmbeddedAssetsPlugin::log("File with name \"{$fileName}\" already exists in this location");
+
 			$fileUniqueId = DateTimeHelper::currentUTCDateTime()->format('ymd_His');
 			$fileName = $filePrefix . $fileLabel . '_' . $fileUniqueId . $fileExtension;
 		}
@@ -250,12 +268,16 @@ private function _addToFiles($key, $url, $data = null, $mimeType = 'text/plain')
 
 		if(function_exists('finfo_open'))
 		{
+			EmbeddedAssetsPlugin::log("Setting embedded asset file mime type with `finfo`");
+
 			$fileInfo = finfo_open(FILEINFO_MIME);
 			$mimeType = finfo_file($fileInfo, $tempName);
 			finfo_close($fileInfo);
 		}
 		else if(function_exists('mime_content_type'))
 		{
+			EmbeddedAssetsPlugin::log("Setting embedded asset file mime type with `mime_content_type`");
+
 			$mimeType = mime_content_type($tempName);
 		}
 
@@ -278,6 +300,8 @@ private function _readExternalFile($url)
 	{
 		if(function_exists('curl_init'))
 		{
+			EmbeddedAssetsPlugin::log("Reading file with `curl`");
+
 			$ch = curl_init();
 
 			curl_setopt($ch, CURLOPT_AUTOREFERER, true);
@@ -291,6 +315,8 @@ private function _readExternalFile($url)
 
 			if(!empty($error))
 			{
+				EmbeddedAssetsPlugin::log("Error reading file (\"{$error}\")", LogLevel::Error);
+
 				$data = false;
 			}
 
@@ -302,6 +328,8 @@ private function _readExternalFile($url)
 		$allowUrlFopen = preg_match('/1|yes|on|true/i', ini_get('allow_url_fopen'));
 		if($allowUrlFopen)
 		{
+			EmbeddedAssetsPlugin::log("Reading file with `file_get_contents`");
+
 			return @file_get_contents($url);
 		}