feat: Support retrieving WriterStrategyBuilder from VortexSession #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comments described this get-or-default, but instead it was a panic --------- Signed-off-by: Nicholas Gates <nick@nickgates.com>
There was a problem hiding this comment.
Pull request overview
This PR enables retrieving a WriterStrategyBuilder from a VortexSession, allowing users to configure the writer strategy used by session.write_options(). The implementation adds new session retrieval methods and updates the trait bounds to support both optional and default-initialized session variables.
Key changes:
- Added
set()method toVortexSessionfor inserting session variables with custom values - Added
get_opt()andget_mut_opt()methods to retrieve optional session variables without requiringDefaultimplementations - Modified
write_options()to check for and use a session-storedWriteStrategyBuilderif available - Added
DebugandClonederives to support storingWriteStrategyBuilderin sessions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vortex-session/src/lib.rs | Adds set() method and optional retrieval methods (get_opt, get_mut_opt) for session variables, updates existing methods to require Default only when auto-inserting |
| vortex-layout/src/layouts/compressed.rs | Adds Debug trait bound to CompressorPlugin trait and its implementations to support session storage |
| vortex-file/src/writer.rs | Updates write_options() to retrieve and use WriteStrategyBuilder from session if available, includes basic test coverage |
| vortex-file/src/strategy.rs | Adds Debug and Clone derives to WriteStrategyBuilder to enable session storage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
phillipleblanc
approved these changes
Dec 10, 2025
lukekim
pushed a commit
that referenced
this pull request
Jan 14, 2026
* Fix session get-or-default (vortex-data#5662) The comments described this get-or-default, but instead it was a panic --------- Signed-off-by: Nicholas Gates <nick@nickgates.com> * feat: Support retrieving writer strategy builder from vortex session --------- Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-authored-by: Nicholas Gates <gatesn@users.noreply.github.com>
lukekim
pushed a commit
that referenced
this pull request
Feb 6, 2026
* Fix session get-or-default (vortex-data#5662) The comments described this get-or-default, but instead it was a panic --------- Signed-off-by: Nicholas Gates <nick@nickgates.com> * feat: Support retrieving writer strategy builder from vortex session --------- Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-authored-by: Nicholas Gates <gatesn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
WriterStrategyBuilderfrom the availableVortexSession, to update the writer strategy used when built viasession.write_options()