CASE WHEN expression with execution context and DataFusion equivalenc… #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates how CASE WHEN expressions are evaluated in both benchmarks and tests, switching from the older
.evaluate()method to the newerapply + executepattern using a session context. This ensures consistency with the main execution path and prepares the codebase for future enhancements. Additionally, a new integration test is added to verify equivalence between Vortex and DataFusion CASE WHEN evaluation.Migration to apply+execute evaluation pattern:
case_when_bench.rsnow use theapply + executepattern with a sharedVortexSessioncontext, replacing direct calls to.evaluate()for more accurate benchmarking of real execution paths. [1] [2] [3] [4] [5]case_when.rsare refactored to use a helper function that evaluates expressions viaapply + executewith a static session, replacing.evaluate()calls throughout. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Testing and correctness improvements:
exprs.rsthat checks the equivalence of CASE WHEN evaluation between DataFusion and Vortex, ensuring that the conversion and execution yield identical results.These changes improve test coverage, future-proof the codebase, and ensure consistency between benchmarks, unit tests, and production execution.