Show supported OS architecture list in installation guide #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Similarily, this ensures Metal devices are selected on model load, and Metal-specific kernels used when possible. | ||
|
|
||
| ### Supported OS Architectures |
There was a problem hiding this comment.
We also support Windows x64.
Also these architecture name are the technical names - I would expect a more user-friendly name here (with the technical name in parenthesis, or if this was formatted as a table, in one of the columns)
* Separate user-friendly info and technical name
Garamda
commented
Feb 24, 2025
| Similarily, this ensures Metal devices are selected on model load, and Metal-specific kernels used when possible. | ||
|
|
||
| ### Supported OS Architectures | ||
| | OS | Architecture | |
There was a problem hiding this comment.
@phillipleblanc How about a table like this?
|
I've added these as part of #879 |
|
Since @lukekim integrated system requirements information on another doc page, I close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Supported OS architecture list is added in installation doc.
When user fails to install spice, the url for that doc will be shown in error message.
🔨 Related Issues
#4780
🤔 Concerns
The website should be deployed first, before spiceai/spiceai#4840 & spiceai/homebrew-spiceai#55 are applied, to make the url (in error msg) valid.
(cf. even if the website is not updated, the url itself makes user land to spiceai.org/docs/installation anyway)