Skip to content

Conversation

@sphuber
Copy link
Owner

@sphuber sphuber commented Jan 17, 2025

The filenames input was not taken into account for RemoteData input nodes.

@sphuber sphuber force-pushed the fix/105/handle-remote-data-argument-placeholders branch from 418e1ce to 1a5dfe8 Compare January 18, 2025 13:37
The `filenames` input was not taken into account for `RemoteData` input
nodes.
@sphuber sphuber force-pushed the fix/105/handle-remote-data-argument-placeholders branch from 1a5dfe8 to f2acef2 Compare January 18, 2025 13:41
@sphuber sphuber marked this pull request as ready for review January 18, 2025 13:41
@sphuber
Copy link
Owner Author

sphuber commented Jan 18, 2025

@agoscinski I think this should solve the problems. It should now properly resolve RemoteData nodes that have placeholders in the arguments taking into account any target directories in filenames, and it should be properly copied over. Please let me know if that works for your use case.

Copy link

@GeigerJ2 GeigerJ2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Let's figure out what we do with #109, and then get this baby merged!

@sphuber sphuber merged commit cfe207d into master May 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants