Support comments in the redirects file #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test that reads a file with comments and verifies redirects are still added? |
|
sure |
|
ci seems to be failing for unrelated reasons tho i think |
|
@Daltz333 sorry, read tests properly adding test now... |
|
CI is operational again. Could you rebase off of master to get the fix? |
phlax
force-pushed
the
comments-in-redirects-file
branch
from
fddfd4a to
76409c2
Compare
TheTripleV
requested changes
Oct 11, 2020
phlax
force-pushed
the
comments-in-redirects-file
branch
from
76409c2 to
fa9161f
Compare
|
@TheTripleV i think ive moved the test to the right place, lmk if there are any further changes required to land |
Daltz333
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows devs to explain why something has been added, or remove after a certain amount of time