Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intersphinx, refactoring and intersphinx_disable_domains #9459
Intersphinx, refactoring and intersphinx_disable_domains #9459
Changes from all commits
961f5af
f22faa7
c88c718
84238df
0d9f4cd
9e1ba75
cfbac2c
778a3fe
e192f62
484d74a
56002be
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any case that
honor_disabled_refs
is True, butinv_name
is None?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is the default for most
pending_xref
:missing_reference
callback it will honor the disabling: https://github.com/jakobandersen/sphinx/blob/778a3fe6a7a4caf9152caa5c9b10d5378de671c2/sphinx/ext/intersphinx.py#L467resolve_reference_detect_inventory
: https://github.com/jakobandersen/sphinx/blob/778a3fe6a7a4caf9152caa5c9b10d5378de671c2/sphinx/ext/intersphinx.py#L446resolve_reference_any_inventory
theNone
is added: https://github.com/jakobandersen/sphinx/blob/778a3fe6a7a4caf9152caa5c9b10d5378de671c2/sphinx/ext/intersphinx.py#L428