Theme: Move body tag into a block - #4140
Merged
Merged
Conversation
Sometimes users might want to override this tag to include custom information such as `id`s e.g:
`<body id="page-top">`
Can be done with `{%- block body_tag %}<body id="page-top">{% endblock %}`
tk0miya
approved these changes
Oct 11, 2017
tk0miya
left a comment
tk0miya
left a comment
Member
There was a problem hiding this comment.
@shibukawa do you have any comments for this?
Contributor
|
This fix is not bad, because it keeps backward compatibility. |
Member
|
Merged. Thank you for contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
Sometimes users might want to override this tag to include custom information such as
ids.Detail
Example:
<body id="page-top">Can be done with
{%- block body_tag %}<body id="page-top">{% endblock %}Relates
None