Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping original signatures for functions/methods #1882

Closed
wants to merge 3 commits into from

Conversation

hypnocat
Copy link

@hypnocat hypnocat commented May 8, 2015

Implements #759
Mentioned in #1859

Sometimes users need exact signatures, and do not want to
override function declaration in autodoc for sphinx
This PR is first attempt to implement this feature.

@Felix-neko
Copy link

Hi! Is anyone going to merge it?

We really need this feature in our project.
^__^

@rndrr
Copy link

rndrr commented Oct 27, 2015

+1

@@ -1,28 +1,15 @@
=================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes to the main Sphinx README make it hard to merge this PR as-is.

@lehmannro
Copy link
Contributor

This branch has conflicts that must be resolved; I believe it clashes with changes introduced in PR #1975.

@Felix-neko
Copy link

Felix-neko commented Dec 19, 2016

Hi! Cannot you please merge it somehow? We really need it for our work...

P.S. Here's a patch for current version of Sphinx: #3263
I've slightly modified it.

@peterjc
Copy link
Contributor

peterjc commented Sep 14, 2017

Should this pull request (#1882) be closed in favour of the updated pull request #3263, which addresses some of the comments raised here?

@Hammond95
Copy link

Will this be included in next releases?

@tk0miya
Copy link
Member

tk0miya commented May 13, 2019

I'm closing this now because no longer updated.
Thank you for proposal.

@tk0miya tk0miya closed this May 13, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants