Followup-to: Fix tests for Python 3.14a7+ (#13514) #13527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates-to commit a81bcf8.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
jayaddison
commented
May 12, 2025
|
@AA-Turner this is ready for review; I've left one question/thought about maybe using an f-string in one of the fixups, but could also argue that consistency makes the changeset simpler. |
AA-Turner
reviewed
May 12, 2025
|
Thanks @AA-Turner! |
jayaddison
commented
May 12, 2025
| @@ -1421,6 +1425,10 @@ def test_autodoc_type_aliases(app: SphinxTestApp) -> None: | |||
| 'io.StringIO': 'my.module.StringIO', | |||
| } | |||
| actual = do_autodoc(app, 'module', 'target.autodoc_type_aliases', options) | |||
| if sys.version_info >= (3, 14, 0, 'alpha', 7): | |||
| attr2_typeinfo = () | |||
There was a problem hiding this comment.
@AA-Turner did you just uncover a bug in mypy? There are two declarations of attr2_typeinfo, and only one was adjusted by 059ee9c - yet the mypy lint job succeeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixup some
autodoc-related tests in a way that handles both before-and-after Py3.14(a7).References