Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rendering math as svg in html and epub output #2179

Closed
xuhdev opened this issue Dec 17, 2015 · 7 comments
Closed

Support rendering math as svg in html and epub output #2179

xuhdev opened this issue Dec 17, 2015 · 7 comments
Labels
extensions type:enhancement enhance or introduce a new feature

Comments

@xuhdev
Copy link
Contributor

xuhdev commented Dec 17, 2015

Rendering math as svg is pretty useful: the vector image would look much nicer than the png correspondence. Although MathJAX can be used for html, it (a) does not work in epub, (b) is heavy (takes time to load), (c) requires javascript.

I have a solution which I've implemented locally, which modifies pngmath to render math as svg images. The major part of the extension is pretty much the same, thus I would prefer to modify pngmath to support svg output. However, the name pngmath would no longer be appropriate. I have a few questions here, if they can be answered, I can make a proper PR:

  • How about renaming pngmath to imgmath? Or simply not renaming (a bit confusing)?
  • If renamed, how to deprecate the old name?
  • The PR should be sent to master, is this correct?

Solving this issue also solves #1570

@xuhdev
Copy link
Contributor Author

xuhdev commented Dec 17, 2015

The hack I'm currently using is available here

@tk0miya
Copy link
Member

tk0miya commented Dec 19, 2015

How about renaming pngmath to imgmath? Or simply not renaming (a bit confusing)?
If renamed, how to deprecate the old name?

To keep compatibility, it would be better adding imgmath as new extension.
And, pngmath should warn deprecated message on importing.

The PR should be sent to master, is this correct?

Yes, please!

@shimizukawa @birkenfeld What do you think?

@birkenfeld
Copy link
Member

Yes, no renames please. Renaming the default theme was painful enough :)

@shimizukawa
Copy link
Member

+1 for no renaming :)

2015年12月19日(土) 18:59 Georg Brandl notifications@github.com:

Yes, no renames please. Renaming the default theme was painful enough :)


Reply to this email directly or view it on GitHub
#2179 (comment).

@xuhdev
Copy link
Contributor Author

xuhdev commented Dec 19, 2015

OK, no renaming :)

@tk0miya tk0miya added type:enhancement enhance or introduce a new feature extensions labels Dec 21, 2015
@xuhdev
Copy link
Contributor Author

xuhdev commented Dec 24, 2015

I have made a PR at #2192 to for this issue :)

@tk0miya
Copy link
Member

tk0miya commented Jan 1, 2016

#2192 is merged now! Thanks a lot!

@tk0miya tk0miya closed this as completed Jan 1, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions type:enhancement enhance or introduce a new feature
Projects
None yet
Development

No branches or pull requests

4 participants