Fix shader uniform memory leaks #317

postcasio · 2020-11-17T01:34:17Z

Free memory for int and float array uniforms when the uniform or shader is destroyed.

fatcerberus

Just a couple minor style complaints; the change looks right to me otherwise.

src/minisphere/galileo.c

fatcerberus

Seems good for now. I'll see if I can find a way to get rid of the code duplication some other time Thanks for finding the memory leak, kind of a silly oversight on my part.

Free memory for int and float array uniforms when the uniform or shader is destroyed.

Fix shader uniform memory leaks

bd1a3f8

Free memory for int and float array uniforms when the uniform or shader is destroyed.

fatcerberus requested changes Nov 17, 2020

View reviewed changes

src/minisphere/galileo.c Outdated Show resolved Hide resolved

src/minisphere/galileo.c Outdated Show resolved Hide resolved

postcasio added 2 commits November 16, 2020 23:34

Fix code style

539b69c

Fix missing empty line before iterator

cac34f5

fatcerberus approved these changes Nov 18, 2020

View reviewed changes

fatcerberus merged commit aaea613 into spheredev:master Nov 18, 2020

fatcerberus pushed a commit that referenced this pull request Nov 22, 2020

Fix shader uniform memory leaks (#317)

e4c343a

Free memory for int and float array uniforms when the uniform or shader is destroyed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix shader uniform memory leaks #317

Fix shader uniform memory leaks #317

postcasio commented Nov 17, 2020

fatcerberus left a comment

fatcerberus left a comment

Fix shader uniform memory leaks #317

Fix shader uniform memory leaks #317

Conversation

postcasio commented Nov 17, 2020

fatcerberus left a comment

Choose a reason for hiding this comment

fatcerberus left a comment

Choose a reason for hiding this comment