Preliminary support for neovim #777

bronzehedwick · 2015-05-11T21:30:58Z

A simple change to support neovim. Fixes #774.

ghost · 2015-05-11T21:49:32Z

for neovim can be break with tradition and rely on the presence of the .nvim directory only? and not create a .nvimrc ? I wanted to do that for regular vim, but @spf13 wanted to keep up with what is expected of vim, even though vim works fine with only a .vim directory.

bronzehedwick · 2015-05-13T13:22:39Z

I'm a little confused; is there a way to have all the functionality inside .nvimrc with only the .nvim directory?

ghost · 2015-05-13T19:30:31Z

It is possible in vim (with just a .vim dir) , before the neovim fork happened. So it is very likely possible in neovim also.

bronzehedwick · 2015-05-13T19:37:49Z

Oh cool, I'll look into that and check back with another PR.

ghost · 2015-05-13T20:43:37Z

@bronzehedwick : i did ask spf13 about relying on that for vim itself, but he thought that too many people were used to having a .vimrc and wouldn't complain if it didn't exist. It's up to you if you think we should be concerned about that for neovim.

bronzehedwick · 2015-05-13T20:48:35Z

@jrobeson ok, gotcha. I still want to investigate it, and see how it works.

bronzehedwick · 2015-05-20T19:35:08Z

Re-opening to make changes.

bronzehedwick · 2015-05-20T19:39:40Z

@jrobeson Finally got around to investing, and after a little trial and error I got the nvimrc file to work inside the .nvim directory. I like the cleanliness of this approach. Thanks for the suggestion!

spf13 · 2015-05-21T20:22:34Z

@jrobeson I'll let you review and merge this one. It looks good to me.

bronzehedwick · 2015-05-31T21:06:57Z

@jrobeson any word on merging this?

ghost · 2015-05-31T22:12:45Z

shouldn't we check if nvim exists before creating potentially unnecessary files? We should probably do the same for vim too.

ghost · 2015-06-01T01:39:55Z

btw: neovim is going to support xdg at some point soon, so we'll have to adjust for that later: neovim/neovim#78

bronzehedwick · 2015-06-01T14:07:37Z

Good point; I wrapped the linking in a check for neovim

ghost · 2015-06-02T21:20:55Z

bootstrap.sh

where does has() come from? This doesn't look valid in a shell script.

Neovim implements it.

neovim might implement it, but vimscript doesn't work inside bootstrap.sh

a shell script if looks more like

if [ "$1" -eq '1' ]; then endif

It seems like your approach (with has('nvim') would only install the nvim symlinks if we were running nvim, but not if we had nvim installed, but were executing it with vim.

It should check for nvim in the $PATH via type or which. We currently use type in program_exists().

I would still like to use has('nvim') in combination with an environment variable to specify that nvim is your only vim, but not as the default.

Something like

ONLY_NVIM=1 bootstrap.sh

Right, of course. I'll refactor this into an actual shell script if.

bronzehedwick · 2015-07-13T00:34:20Z

I updated the code to fix the issue of using has('nvim').

bronzehedwick · 2015-07-16T14:22:07Z

@jrobeson any chance of getting this merged? Does the PR still need work?

ghost · 2015-07-27T03:54:08Z

thanks @mkwmms ! I wouldn't have noticed that line 39 issue!

mwilliammyers · 2015-07-28T00:56:12Z

@jrobeson no problem!

bronzehedwick · 2015-07-29T15:12:09Z

Ack, what was I thinking! Thanks for the catch @mkwmms. The code should be corrected now.

spf13 · 2015-08-03T16:39:43Z

@jrobeson You're much more familiar with this than I am. It all LGTM. Can you merge when you feel it's in a good place?

ghost · 2015-08-08T21:55:48Z

bootstrap.sh

why aren't we using program_exists here? is that not good enough somehow?

As @mkwmms mentioned, program_exists will exit the script if neovim is not found.

hah, yeah that was it. I must have been barely awake when I made that comment. I think I'd like to see program_exists renamed to something that indicates it's a fatal error, and then use program_exists for what you're doing with nvim_exists

OK, sounds good. I'll refactor to that.

mwilliammyers · 2015-08-11T19:55:08Z

Should I go ahead and wait for these changes and then incorporate them into #814 ?

ghost · 2015-08-11T21:50:30Z

I don't see a reason to wait.

bronzehedwick · 2015-08-12T19:03:01Z

@jrobeson I refactored the naming of the functions and generalized the functionality of what was nvim_exists.

bronzehedwick · 2015-08-27T21:57:19Z

@jrobeson have you by chance had a moment to review this?

ghost · 2015-08-27T22:06:52Z

@mkwmms : what do you think? I'm questioning my own decisions after missing that exit :(

mwilliammyers · 2015-08-28T07:05:17Z

bootstrap.sh

I would make this: if [ "$ret" -ne 0 ]; then

Ha, makes sense!

mwilliammyers · 2015-08-28T07:12:42Z

@jrobeson haha it's all good, happens to all of us. For the most part 👍, just some minor things...

mwilliammyers · 2015-08-30T23:46:49Z

@bronzehedwick nice work, this will be very handy for all of us who like a more modern vim 😄

bronzehedwick · 2015-08-31T00:41:14Z

😆
On Sun, Aug 30, 2015 at 7:46 PM william notifications@github.com wrote:

@bronzehedwick https://github.com/bronzehedwick nice work, this will be
very handy for all of us who like a more modern vim [image: 😄]

—
Reply to this email directly or view it on GitHub
#777 (comment).

ghost · 2015-08-31T02:16:20Z

now it just needs squash/rebase and it will be good to go.

bronzehedwick · 2015-08-31T13:48:02Z

Done and done.

ghost · 2015-08-31T19:18:27Z

i still see 9 commits ?

A simple change to support neovim. Fixes spf13#774. Move nvimrc file inside .nvim directory Only install neovim support if neovim is being used Use program_exists function instead of vimscript Made a hasty mistake and added vimscript to a bash script :X Neovim not existing no longer stops script Also correct `endif` to `fi`. Refactor program_exists naming Changed `program_exists` to `program_must_exist`, which throws an error which halts the script if the program is not found, and refactored `nvim_exists` to be the more general `program_exists`, which does not throw an error if the program is not found. Refactor program_exists and program_must_exist `program_must_exist` uses `program_exists` now, instead of repeating code. Changed `type` to `command -v` in `program_exists` to be more POSIX compliant. Refactored status code conditional in `program_exists` to remove double negatives. Thanks to @mkwmms for the suggestions. Preliminary support for neovim A simple change to support neovim. Fixes spf13#774. Move nvimrc file inside .nvim directory Refactor program_exists naming Changed `program_exists` to `program_must_exist`, which throws an error which halts the script if the program is not found, and refactored `nvim_exists` to be the more general `program_exists`, which does not throw an error if the program is not found. Refactor program_exists and program_must_exist `program_must_exist` uses `program_exists` now, instead of repeating code. Changed `type` to `command -v` in `program_exists` to be more POSIX compliant. Refactored status code conditional in `program_exists` to remove double negatives. Thanks to @mkwmms for the suggestions.

bronzehedwick · 2015-09-02T13:51:44Z

@jrobeson Oops, didn't force push. Should be fixed now :)

Preliminary support for neovim

ghost · 2015-10-26T05:33:48Z

@bronzehedwick : this needs to be redone now. XDG support has been merged into neovim

ghost · 2015-10-26T05:34:21Z

neovim/neovim@1ca5646

ghost mentioned this pull request May 11, 2015

Neovim support #774

Closed

bronzehedwick closed this May 13, 2015

bronzehedwick reopened this May 20, 2015

bronzehedwick mentioned this pull request May 21, 2015

Feature request: suggest best way to get Vim +lua #783

Open

ghost reviewed Jun 2, 2015
View reviewed changes

ghost reviewed Aug 8, 2015
View reviewed changes

mwilliammyers reviewed Aug 28, 2015
View reviewed changes

bronzehedwick force-pushed the patch-1 branch from 6d80007 to 9f78da8 Compare September 2, 2015 13:51

ghost pushed a commit that referenced this pull request Sep 2, 2015

Merge pull request #777 from bronzehedwick/patch-1

748e494

Preliminary support for neovim

ghost merged commit 748e494 into spf13:3.0 Sep 2, 2015

ghost mentioned this pull request Oct 26, 2015

*nix preliminary XDG support #814

Open

This pull request was closed.

Preliminary support for neovim #777

Preliminary support for neovim #777

Uh oh!

Conversation

bronzehedwick commented May 11, 2015

Uh oh!

ghost commented May 11, 2015

Uh oh!

bronzehedwick commented May 13, 2015

Uh oh!

ghost commented May 13, 2015

Uh oh!

bronzehedwick commented May 13, 2015

Uh oh!

ghost commented May 13, 2015

Uh oh!

bronzehedwick commented May 13, 2015

Uh oh!

bronzehedwick commented May 20, 2015

Uh oh!

bronzehedwick commented May 20, 2015

Uh oh!

spf13 commented May 21, 2015

Uh oh!

bronzehedwick commented May 31, 2015

Uh oh!

ghost commented May 31, 2015

Uh oh!

ghost commented Jun 1, 2015

Uh oh!

bronzehedwick commented Jun 1, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bronzehedwick commented Jul 13, 2015

Uh oh!

bronzehedwick commented Jul 16, 2015

Uh oh!

ghost commented Jul 27, 2015

Uh oh!

mwilliammyers commented Jul 28, 2015

Uh oh!

bronzehedwick commented Jul 29, 2015

Uh oh!

spf13 commented Aug 3, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwilliammyers commented Aug 11, 2015

Uh oh!

ghost commented Aug 11, 2015

Uh oh!

bronzehedwick commented Aug 12, 2015

Uh oh!

bronzehedwick commented Aug 27, 2015

Uh oh!

ghost commented Aug 27, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!