Support OnlySubCommands for validation of positional arguments #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perif
reviewed
May 31, 2018
README.md
Outdated
| @@ -392,6 +392,7 @@ The following validators are built in: | |||
| - `NoArgs` - the command will report an error if there are any positional args. | |||
| - `ArbitraryArgs` - the command will accept any args. | |||
| - `OnlyValidArgs` - the command will report an error if there are any positional args that are not in the `ValidArgs` field of `Command`. | |||
| - `OnlySubCommands` - the command will report an error if if any args are included except for subcommands. | |||
There was a problem hiding this comment.
Thank you @Perif Updated.
Currently, suggestions for "unknown command" are not working for subcommands. This patch supports new validation of positional arguments as `OnlySubCommands`. It accepts only subcommands if enabled, and also `findSuggestions()` will be called.
4 tasks
|
This PR is being marked as stale due to a long period of inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, suggestions for "unknown command" are not working for
subcommands.
This patch supports new validation of positional arguments as
OnlySubCommands. It accepts only subcommands if enabled, and alsofindSuggestions()will be called.Fixes #636