Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing http:// to https:// #1360

Closed
wants to merge 1 commit into from
Closed

Conversation

niko-dunixi
Copy link

@niko-dunixi niko-dunixi commented Mar 2, 2021

Various licenses, both in the file comments and in the
strings used for generating new CLI tools, use the http
protocol. Browsers should redirect to https automatically
but why not cut to the heart and directly go to the secure
protocol.

This was performed via 'find' and 'sed':
find . -type f -iname '*.go' -iname '*.golden' -exec sed -i '' -e 's/http:\/\//https:\/\//' \{\} \;

@CLAassistant
Copy link

CLAassistant commented Mar 2, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli area/docs-generation Generation of docs via Cobra labels Mar 2, 2021
Various licenses, both in the file comments and in the
strings used for generating new CLI tools, use the http
protocol. Browsers should redirect to https automatically
but why not cut to the heart and directly go to the secure
protocol.

This was performed via 'find' and 'sed':
`find . -type f -iname '*.go' -iname '*.golden'  -exec sed -i '' -e 's/http:\/\//https:\/\//' \{\} \;`
@niko-dunixi niko-dunixi force-pushed the master branch 2 times, most recently from f6b6886 to 2c5b3e3 Compare March 3, 2021 17:34
@niko-dunixi
Copy link
Author

Not sure what's not working, it appears to be an environment issue specific to MINGW64. It's not really obvious what the problem is:

Run export GOBIN=$HOME/go/bin
golangci/golangci-lint info checking GitHub for tag 'latest'
golangci/golangci-lint info found version: 1.38.0 for v1.38.0/windows/amd64
Archive:  golangci-lint-1.38.0-windows-amd64.zip
  inflating: golangci-lint-1.38.0-windows-amd64/LICENSE  
  inflating: golangci-lint-1.38.0-windows-amd64/README.md  
  inflating: golangci-lint-1.38.0-windows-amd64/golangci-lint.exe  
golangci/golangci-lint info installed /home/runneradmin/go/bin/golangci-lint.exe
no required module provides package github.com/kyoh86/richgo; to add it:
	go get github.com/kyoh86/richgo
Error: Process completed with exit code 1.

@github-actions
Copy link

github-actions bot commented May 3, 2021

This PR is being marked as stale due to a long period of inactivity

@marckhouzam
Copy link
Collaborator

Thanks for the contribution @paul-nelson-baker.
In the long time it took us to get around to looking at your PR, the Cobra generator has moved to https://github.com/spf13/cobra-cli, so this PR would need to be updated.

However, if I look at the official text of the Apache license, it still uses http...
https://www.apache.org/licenses/LICENSE-2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli area/docs-generation Generation of docs via Cobra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants