Output usage hint for both unknown subcommand and unknown flag in the same way #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgn
force-pushed
the
unknown-subcommand-unknown-flag-consistency
branch
2 times, most recently
from
d94f662 to
b040f11
Compare
dgn
force-pushed
the
unknown-subcommand-unknown-flag-consistency
branch
from
b040f11 to
91783a0
Compare
|
|
jharshman
added
the
area/lib
|
This PR is being marked as stale due to a long period of inactivity |
|
Bump! |
|
@spf13 can you please merge this commit? We need it! |
hoshsadiq
pushed a commit
to zulucmd/zulu
that referenced
this pull request
Dec 31, 2022
Now, when you try to run a Command with an unknown sub-command vs. an unknown flag, you'll get: ``` $ testcommand asdsa Error: unknown command "asdsa" for "testcommand" Run 'testcommand --help' for usage. $ testcommand --asdsa Error: unknown flag: --asdsa $ testcommand -asdsa Error: unknown shorthand flag: 'a' in -asdsa ``` With these changes, you'll get: ``` $ testcommand asdsa Error: unknown command "asdsa" for "testcommand" Run 'testcommand --help' for usage. $ testcommand --asdsa Error: unknown flag: --asdsa Run 'testcommand --help' for usage. $ testcommand -asdsa Error: unknown shorthand flag: 'a' in -asdsa Run 'testcommand --help' for usage. ``` Merge spf13/cobra#1023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, when you try to run a Command with an unknown sub-command vs. an unknown flag, you'll get:
With these changes, you'll get: