Completer scripts broken in PowerShell 7.3+

[pinkfloydx33]

PowerShell 7.3 has corrected a long-standing bug with quote escaping during native argument passing. This causes existing quoting work-arounds to break. In it's current form, the completer scripts no longer work in PowerShell 7.3+ when using the new default settings and attempting to complete an empty command (ie. command [tab] vs command s[tab]).

The offending lines:

cobra/powershell_completions.go

Lines 109 to 110 in 6b0bd30

	`+" # We need to use `\"`\" to pass an empty argument a \"\" or '' does not work!!!"+`
	`+" $RequestComp=\"$RequestComp\" + ' `\"`\"'"+`

It's sort of hard to see, but the single back ticks escaping the quotes near the end of line 110 need to be removed. However it's dependent on both the version of PowerShell and the new preference variable for native command arguments, $PSNativeCommandArgumentPassing, so a better fix is likely the following (note this is in PowerShell, not as an embedded go string) :

# We need to use `"`" to pass an empty argument a "" or '' does not work!!!
# PowerShell 7.3+ need to use "" if Argument Passing is not Legacy	
if ($PSVersionTable.PsVersion -lt [version]'7.3.0' -or $PSNativeCommandArgumentPassing -eq 'Legacy') {
     $RequestComp="$RequestComp" + ' `"`"'
} else {
     $RequestComp="$RequestComp" + ' ""'
}

I'm not sure if that's the most elegant fix nor if it is 100% correct given that there's multiple modes (Legacy, Standard and Windows). I'm also not sure if the script needs any other modifications, though in my limited testing it is has fixed all of the completer scripts I use that were generated via this library (ie. flux/helm/kustomize)

See GitHub issues here and here as well as documentation for PSNativeCommandArgumentPassing (which despite being on the experimental features page is actually mainstream/GA in 7.3)

[marckhouzam]

cc @Luap99

[Luap99]

Feels weird that they changed it in a minor release version.
I don't use powershell any more but if this works for all versions please open a PR with your suggested fix.

[github-actions]

The Cobra project currently lacks enough contributors to adequately respond to all issues. This bot triages issues and PRs according to the following rules:

• After 60d of inactivity, lifecycle/stale is applied. - After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied and the issue is closed.
  You can:
• Make a comment to remove the stale label and show your support. The 60 days reset. - If an issue has lifecycle/rotten and is closed, comment and ask maintainers if they'd be interested in reopening

[oldium]

@pinkfloydx33 Your solution looks good (at least I came to the exact same solution). Are you going to create a Pull Request for this change?

[oldium]

Created Pull Request #1916 to fix the issue. It supports PowerShell 7.2, where you can enable it as an experimental feature.