Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long relative path handling on windows #302

Closed
wants to merge 2 commits into from

Conversation

sandreas
Copy link

@sandreas sandreas commented May 9, 2021

On windows long relative paths led to an error (see golang/go#21782). Here is a code example that fails (only on windows, on play it works): https://play.golang.org/p/wMS5gti4SD

To reproduce it you may use this on windows 10:

mkdir C:\inetpub\wwwroot\something_4.0\node_modules\babel-preset-es2015\node_modules\babel-plugin-transform-es2015-block-scoping\node_modules\babel-traverse\node_modules\babel-code-frame\node_modules\chalk\node_modules\strip-ansi\node_modules\ansi-regex\
echo "" > C:\inetpub\wwwroot\something_4.0\node_modules\babel-preset-es2015\node_modules\babel-plugin-transform-es2015-block-scoping\node_modules\babel-traverse\node_modules\babel-code-frame\node_modules\chalk\node_modules\strip-ansi\node_modules\ansi-regex\test.txt

And then use the afero.Walk on C:\inetpub\wwwroot\something_4.0\ with a relative path traversal (e.g. . or node_modules).

Other projects solve this problem in a similar way:

@CLAassistant
Copy link

CLAassistant commented May 9, 2021

CLA assistant check
All committers have signed the CLA.

@sandreas
Copy link
Author

Is there any plan to merge this or give feedback? Otherwise I can close this...

@sandreas
Copy link
Author

sandreas commented Jan 29, 2023

Closed due to no feedback within > 18 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants