Remove query_short_channel_ids zlib compression #9470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yep, I ran into the same issue when testing onion messages against c-lightning and had a similar patch parked in a local branch for testing. Good to see this is indeed part of the spec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We send the query_short_channel_ids gossip message with zlib compression encoding enabled by default. However this was removed/forbidden in the bolt spec in this PR lightning/bolts#981 and must not be done anymore, see https://github.com/lightning/bolts/blob/master/07-routing-gossip.md#query-messages. I removed the compression part completely as i see no case where it could be used anymore.