synchronizer: show progress in GUI (take 1) (num_addrs, num_txs) #5312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomberNight
added
user-interface 🔲
topic-wallet 👛
|
Wow, cool! Any reason not to show a progress bar? |
What would you consider 100%? You don't know how many addrs/txs there will be :/ |
|
related: #2094 |
SomberNight
changed the title
SomberNight
changed the title
|
I think #5319 is superior, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the user should be shown some details regarding the progress/state of the history sync.
This has become even more relevant recently, with servers getting DDOS-ed and as a consequence becoming slower/less responsive.
Instead of
Synchronizing...,we now display
Synchronizing... ({num_subs} addrs, {num_txs} txs)num_subsis the number of addresses for which the client sentblockchain.scripthash.subscribeand received the initial scripthash status from the server,num_txsis the number of "raw hex" transactions that are already stored in the wallet(I know, the kivy version is somewhat ugly; I can try to improve it)