Repository navigation
Jit forward checks - #11001
Open
ecdsa wants to merge 3 commits into
Open
Jit forward checks#11001ecdsa wants to merge 3 commits into
ecdsa wants to merge 3 commits into
Conversation
…hannel open_channel_just_in_time was called before the cltv and amount checks on the incoming htlc. Now the JIT path runs the same checks, using the fee and cltv delta of the JIT route hint, and an empty channel_update.
…tingFailure create_onion_for_route raises exceptions that are not OnionRoutingFailure, in which case incoming htlcs were never failed: - PaymentFailure, if the outgoing cltv, which is chosen by the sender, is too far in the future. Check it before, and also reject an already expired outgoing cltv. - InvalidPayloadSize, if the inner trampoline onion does not fit in the outgoing onion. Fail with INVALID_ONION_PAYLOAD. Also fail with TEMPORARY_NODE_FAILURE on any other exception.
ecdsa
marked this pull request as ready for review
September 28, 2026 14:28
Member
|
minimally related: I think we should somehow mark the JIT code as experimental, to communicate that to readers/llms. I think it's not written anywhere that this code is not expected to be used in production atm. electrum/electrum/simple_config.py Lines 975 to 984 in a03a632 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue FWD-2 was only partially fixed; this should cover the rest of the issue