Repository navigation
refactor coin filtering, combine frozen and coincontrol into new class CoinFilter - #10918
Open
accumulator wants to merge 5 commits into
Open
accumulator wants to merge 5 commits into
accumulator wants to merge 5 commits into
Conversation
accumulator
force-pushed
the
coincontrol_frozen_refactor
branch
from
August 31, 2026 15:30
db572f7 to
e1f5e52
Compare
accumulator
added
the
topic-wallet 👛
accumulator
force-pushed
the
coincontrol_frozen_refactor
branch
3 times, most recently
from
September 4, 2026 09:02
26c145d to
f65ca30
Compare
accumulator
marked this pull request as ready for review
September 4, 2026 15:19
Closed
Closed
accumulator
force-pushed
the
coincontrol_frozen_refactor
branch
from
September 8, 2026 07:13
f65ca30 to
6393c83
Compare
…s CoinFilter. Currently, the code for coin control is separate from frozen addresses/coins, and an active coin control selection must be filtered against the frozen list by the caller the moment the selection is used. This commit is an attempt to unify the filtering, so filtering works in predictable ways everywhere (and can e.g. be more easily be extended in the future, if needed) a CoinFilter instance is owned by each wallet, and takes care of managing the list of frozen coins/addresses and the coin control set. Upon query, additional filters like nonlocal_only, confirmed_only are applied.
accumulator
force-pushed
the
coincontrol_frozen_refactor
branch
from
September 9, 2026 14:32
6393c83 to
d20f05e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor coin filtering, combine frozen and coincontrol into new class
CoinFilter.Currently, the code for coin control is separate from frozen addresses/coins, and
an active coin control selection must be filtered against the frozen list by the caller
the moment the selection is used.
This commit is an attempt to unify the filtering, so filtering works in predictable
ways everywhere (and can e.g. be more easily be extended in the future, if needed)
a
CoinFilterinstance is owned by each wallet, and takes care of managing the listof frozen coins/addresses and the coin control set. Upon query, additional filters like
nonlocal_only,confirmed_onlyare applied.CoinFilteremits callbacks when the set of frozen coins/addresses is changed, or whencoin control selection changes.