Fix checksum calculation following BIP-128 standard#10524
Fix checksum calculation following BIP-128 standard#10524oren-z0 wants to merge 1 commit intospesmilo:masterfrom
Conversation
Non-Ascii characters should not be converted for checksum calculation. This will give consistent hash to BIP-128 and its Javascript code example. Timelock-Recovery Plans that contained only ascii characters are not affected.
b65d72e to
edf4055
Compare
|
Which field could contain non-ascii characters? I guess
Are you saying the current python code does not produce the same hash as the example at the end of the BIP? A unit test would be nice. |
|
Yes, "wallet_name" could contain non-ascii character. Yes, if using |
Non-Ascii characters should not be converted for
checksum calculation.
This will give consistent hash to BIP-128 and its
Javascript code example.
Timelock-Recovery Plans that contained only ascii
characters are not affected.