docs: add note for zsh users to quote extras during pip install #10222
Conversation
|
This PR only modifies README.md, so the failing test_payment_multipart_trampoline_e2e in test_lnpeer.py seems unrelated. Could we re-run the CI job? |
| > when installing. To fix this, quote the extras like so: | ||
| > | ||
| > ```bash | ||
| > python3 -m pip install --user '.[fast]' |
There was a problem hiding this comment.
AFAICT all mentions of "pip install ..." with extras already has it quoted.
For example:
Line 26 in c1ab6cd
electrum/contrib/osx/README_macos.md
Line 31 in c1ab6cd
If you find one that does not, you can add quotes at there.
There was a problem hiding this comment.
I guess if you think that helps, we could quote even the lone dots. e.g.
$ python3 -m pip install --user -e "."
|
|
||
| ### Development version (git clone) | ||
|
|
||
| $ python3 -m pip install --user -e . |
There was a problem hiding this comment.
why add this command here? In terms of ordering, this does not make sense for this section.
The command already appears on line 107:
Line 107 in c1ab6cd
|
Thanks but I think this is overkill :) |
Adds a short note for zsh users explaining that they must quote extras
(e.g.
pip install '.[fast]') when installing to avoid "no matches found"errors caused by shell globbing.