adb: change API of util.TxMinedInfo: height() is now always SPV-ed #10216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomberNight
added
topic-transactions 📑
SomberNight
force-pushed
the
202509_adb_spv
branch
from
96ac1da to
4d0a082
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ecdsa
reviewed
Sep 24, 2025
electrum/util.py
Outdated
| header_hash: Optional[str] = None # hash of block that mined tx | ||
| wanted_height: Optional[int] = None # in case of timelock, min abs block height | ||
|
|
||
| def height(self, *, requires_spv: bool = True) -> int: |
There was a problem hiding this comment.
require_spv is unused, do we really need to add this option?
There was a problem hiding this comment.
You're right. I had anticipated that to be needed but ended up not using it anywhere.
Force-pushed in https://github.com/spesmilo/electrum/compare/4d0a082e1e3b636af8e6b9dd955dee6e67eaa5ac..a4293c483e3ac3d83b501d8de1fe11799d9f818e
SomberNight
force-pushed
the
202509_adb_spv
branch
from
4d0a082 to
a4293c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conceptually this is quite an invasive change that transforms unverified txs to unconfirmed txs.
I think it is a code-safety improvement that might prevent security-bugs.
In particular the TxInput.block_height and TxInput.spent_height not being SPV-ed was really bothering me. This fixes that.