No warning if wallet is not protected with password upon creation

[leafcutterant]

2.7.18, Windows standalone version

I was playing around with wallet creation and was surprised that leaving the password boxes empty, I could pass the password-setting screen without any warnings.

Storing seeds and xprv's unencrypted is not a good idea and could do much harm to the unwary novice user. How about making this opt-out? Like, when it's not a watch-only wallet, letting the user though only after ticking a box in a pop-up message that "I've understood the risks" and pressing "OK, proceed unprotected".

[AbdussamadA]

Actually often what happens is that people forget their passwords and lose their bitcoins that way. People getting hacked is much more rare occurrence. Besides the thinking goes that if someone has access to your computer then they can just install a key logger and get your password that way. Even bitcoin core doesn't ask you to set a password by default for these reasons.