Activity

1. SomberNight

   self-assigned this

   on Aug 4, 2025
2. SomberNight

   added

   bug 🐞

   topic-wallet 👛related to wallet.py, or maybe address_synchronizer.py/coinchooser.pyrelated to wallet.py, or maybe address_synchronizer.py/coinchooser.py

   on Aug 4, 2025
3. SomberNight

   added 2 commits that reference this issue on Aug 4, 2025

   WalletDB: add more asserts to {add,get}|_verified_tx

   ...

   4d90ab9

   wallet: change adb_added_verified_tx evt API, passthrough txminedinfo

   ...

   38241ff
4. SomberNight commented on Aug 4, 2025

   

   SomberNight

   on Aug 4, 2025

   Member

   More actions

   The cause is likely 197933d.
   SPV finishes before we receive the full tx.
   (we should add a test case for this)
5. SomberNight

   added this to the 4.6.2 milestone on Aug 4, 2025
6. SomberNight commented on Aug 15, 2025

   

   SomberNight

   on Aug 15, 2025

   Member

   More actions

   maybe related: https://bitcointalk.org/index.php?topic=5552265.0
7. SomberNight

   modified the milestones: 4.6.2, 4.6.3 on Aug 20, 2025
8. SomberNight

   modified the milestones: 4.7.0, 4.8.0 on Jan 5, 2026
9. SomberNight

   modified the milestones: 4.8.0, 4.9.0 on Jun 29, 2026
10. devdavidejesus commented on Oct 9, 2026

    

    devdavidejesus

    on Oct 9, 2026

    Contributor

    More actions

    I could reproduce this on master (89dda29) with a unit test, following your note about 197933d: an unsigned (partial) tx saved as local, e.g. by the txbatcher, gets mined, and SPV finishes before we download the signed tx. adb.get_tx_height() then returns LOCAL (no timestamp, conf=0), wallet.on_event_adb_added_verified_tx sends that with the verified event, and QETransactionListModel.on_tx_verified() fails with the traceback from this issue.

    test (tests/qml/test_qml_txlist_verified.py)

    import gc
    
    from electrum import SimpleConfig
    from electrum.address_synchronizer import TX_HEIGHT_UNCONFIRMED
    from electrum.bitcoin import address_to_script
    from electrum.fee_policy import FixedFeePolicy
    from electrum.gui.qml.qetransactionlistmodel import QETransactionListModel
    from electrum.transaction import PartialTxOutput, Transaction
    from electrum.util import TxMinedInfo
    
    from .. import ElectrumTestCase, restore_wallet_from_text__for_unittest
    
    
    class TestTxListVerifiedEvent(ElectrumTestCase):
        TESTNET = True
    
        @classmethod
        def setUpClass(cls):
            super().setUpClass()
            # free the QObjects (and the wallets they hold) before other tests check for lingering wallets
            cls.addClassCleanup(gc.collect)
    
        async def test_tx_verified_before_we_have_the_signed_tx(self):
            # see #10098
            config = SimpleConfig({'electrum_path': self.electrum_path})
            wallet = restore_wallet_from_text__for_unittest(
                'bitter grass shiver impose acquire brush forget axis eager alone wine silver', path=None, config=config)['wallet']
            addr1, addr2 = wallet.get_receiving_addresses()[:2]
            spk = address_to_script(addr1)
            funding_tx = Transaction(
                '02000000' + '01' + '11' * 32 + '00000000' + '00' + 'fdffffff'
                + '01' + (100_000).to_bytes(8, 'little').hex() + bytes([len(spk)]).hex() + spk.hex()
                + '00000000')
            wallet.adb.receive_tx_callback(funding_tx, tx_height=TX_HEIGHT_UNCONFIRMED)
            # an unsigned tx saved as local, e.g. by the txbatcher before signing it
            tx = wallet.make_unsigned_transaction(
                outputs=[PartialTxOutput.from_address_and_value(addr2, 50_000)], fee_policy=FixedFeePolicy(1000))
            txid = tx.txid()
            self.assertTrue(wallet.adb.add_transaction(tx))
            model = QETransactionListModel(wallet)
            # deliver the 'verified' event below ourselves: an exception in a Qt slot would abort the test run
            model.unregister_callbacks()
            # the signed tx got mined, and SPV finishes before we download it
            wallet.adb.receive_history_callback(addr2, [(txid, 100)], {})
            wallet.adb.add_verified_tx(txid, TxMinedInfo(_height=100, conf=1, timestamp=1700000000, txpos=1, header_hash='00' * 32))
            info = wallet.adb.get_tx_height(txid)  # what wallet.on_event_adb_added_verified_tx sends
            self.assertIsNone(info.timestamp)
            model.on_tx_verified(txid, info)
            item = model.tx_history[model._tx_positions[txid]]
            self.assertEqual('local', item['section'])
            self.assertIsNone(item['timestamp'])

    From reading #10107: with its new assert in add_verified_tx (info2.conf > 0), this case would fail there instead, since get_tx_height() returns conf=0 for it.

    I have a small fix on the QML side: on_tx_verified() handles a missing timestamp the same way tx_to_model() does (section local/mempool, status text from wallet.get_tx_status()), with this test. Would you like a PR for that, or would you rather handle this case in the adb / in #10107?