Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not picking up US Senator designations via "jr/sr" #518

Closed
tmtmtmtm opened this issue Mar 4, 2023 · 2 comments
Closed

Not picking up US Senator designations via "jr/sr" #518

tmtmtmtm opened this issue Mar 4, 2023 · 2 comments

Comments

@tmtmtmtm
Copy link

tmtmtmtm commented Mar 4, 2023

US Senators used to be designated in their infobox via a "jr/sr" parameter. This is now deprecated, but remnants of it still remain, and it resurfaces from time to time — for example it's currently included in Joe Biden's:

| jr/sr3              = United States Senator
| state3              = [[Delaware]]
| term_start3         = January 3, 1973
| term_end3           = January 15, 2009
| predecessor3        = [[J. Caleb Boggs]]
| successor3          = [[Ted Kaufman]]

But wtf_wikipedia (as of 10.1.2) skips the 'jr/sr3' value, leaving this section with no "key" to say what sort of role it is:

          "successor2": {
            "text": "Mike Pence",
            "links": [
              {
                "type": "internal",
                "page": "Mike Pence"
              }
            ]
          },
          "state3": {
            "text": "Delaware",
            "links": [
              {
                "type": "internal",
                "page": "Delaware"
              }
            ]
          },
          "term_start3": {
            "text": "January 3, 1973"
          },

Even though this probably shouldn't be appearing (and will probably get removed again), it would be good if wtf_wikipedia could handle it in the cases where it does, especially as these tend to be quite high-profile pages.

spencermountain added a commit that referenced this issue Mar 4, 2023
@spencermountain
Copy link
Owner

good catch! got a fix on dev branch, will be in the next release.
thanks

@spencermountain
Copy link
Owner

should work now, in 10.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants