Add safety for reserved words in buildNet #1063
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I was playing around with my pet project - and suddenly added word
constructor
as matcher forbuildNet
:And when tried to run the code - it crashed because it tries to call
push
method onobject.constructor
which is a function.I've fixed it via explicitly checking for types. What do you think?
P.S. Also not sure if thats the best place for test - feel free to point me into right direction. Thanks!