Add new Windows host_unique registry option#930
Merged
KaliPatriot merged 16 commits intospellshift:mainfrom May 6, 2025
KaliPatriot:reg-host-unique
Merged
Add new Windows host_unique registry option#930KaliPatriot merged 16 commits intospellshift:mainfrom KaliPatriot:reg-host-unique
KaliPatriot merged 16 commits intospellshift:mainfrom
KaliPatriot:reg-host-unique
Conversation
First time doing rust, will this work chat?
hulto
reviewed
May 5, 2025
Collaborator
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
Nice! Great first PR @LByrgeCP !
I'll take another pass on the morning but looks really good!
implants/lib/host_unique/Cargo.toml
Outdated
| log = { workspace = true } | ||
|
|
||
| [target.'cfg(target_os = "windows")'.dependencies] | ||
| winreg = "0.55" |
Collaborator
There was a problem hiding this comment.
I think we import winreg at the workspace for some of the eldritch functions.
Switch to using workspace = true to use it.
Doing this keeps all the dependencies on the same version and makes it more manageable.
hulto
approved these changes
May 5, 2025
Collaborator
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
Looks good to me!
Just waiting for tests to pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a new host_unique selector for Windows hosts utilizing the registry. It is not enabled by default due to not being cross-platform. However, it will compile correctly non-Windows imix binaries even when enabled (the selector will return None). Registry keys are typically harder to monitor for changes/reads, which overall increases OPSEC and decreases the likeliness of tampering with host ids.
Which issue(s) this PR fixes: