Add a method to TaskHandle to ensure tokio JoinSets are awaited#925
Closed
Add a method to TaskHandle to ensure tokio JoinSets are awaited#925
Conversation
hulto
approved these changes
May 4, 2025
Collaborator
Author
|
this fix option does hang on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though the tokio JoinSet docs claim
We are seeing some sort of race condition on faster tomes where this behavior is not occurring(and thus the JoinSet for reporting back output is never executing). To fix this I added a
joinmethod forTaskHandleso that way in theAgent.reportmethod we can call it on finishedTaskHandles. This should be safe from hanging the thread asis_finished(which is called before) ensures that the pool is empty and theRuntime'sJoinHandleis finsihed./kind bug
Fixes #754