Conversation
hulto
approved these changes
Apr 6, 2025
Collaborator
Author
|
Tested via local deploy of docker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Which issue(s) this PR fixes:
We are encountering Unexpected Application Error!Minified React error #130.
This can be caused by misalignments in import styles and there may be an issue related the MobileNav changes using newer versions of HeadlessUI where other pages are using deprecated versions.
More detailed explanation/understanding of the potential cause:
The new change was starting to use the newer version of Transition and Dialog where their internal components are now imported separately (ie: TranslationChild instead of Translation.Child). Since other locations in the repo used Translation.Child, there were 2 versions of the same component that were getting used in different parts. If the version of the Translation which required TranslationChild to be imported separately we loaded first then Translation.Child version would break and vice versa.