Skip to content

Show Tomes with No Repo #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Show Tomes with No Repo #864

wants to merge 2 commits into from

Conversation

jabbate19
Copy link
Collaborator

@jabbate19 jabbate19 commented Feb 23, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Shows tomes with no repository in the tomes menu.
image

Which issue(s) this PR fixes:

N/A

@jabbate19 jabbate19 requested a review from cmp5987 February 23, 2025 05:45
@cmp5987
Copy link
Collaborator

cmp5987 commented Mar 5, 2025

Can you expand on when this occurs?

My understanding is we always want tomes to either exist as 'first party' or be imported via Repository. Going to ping @hulto or @KCarretto as well to get more discussion around this topic.

@jabbate19
Copy link
Collaborator Author

Can you expand on when this occurs?

My understanding is we always want tomes to either exist as 'first party' or be imported via Repository. Going to ping @hulto or @KCarretto as well to get more discussion around this topic.

There is still a createTomes GraphQL method that can be used to add individual tomes without a repo. Sometimes when I’m working quick I don’t want to have to add it to a repo to use

@hulto
Copy link
Collaborator

hulto commented Mar 7, 2025

I see what you're saying.
Do we want to continue to support the upload tome API?
I think it's usually slower to format and upload a tome esp with assets to the API instead of through git.

@jabbate19
Copy link
Collaborator Author

I see what you're saying. Do we want to continue to support the upload tome API? I think it's usually slower to format and upload a tome esp with assets to the API instead of through git.

If we end up creating ad-hoc tomes (I think this would be a neat feature) having this graphql api would be nice.

I haven't found using the API to be slow. The escape strings cyberchef module does all the changes you need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants